Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ze_querying_subscriber_get method #200

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Nov 22, 2023

Add ze_querying_subscriber_get method as wrapper for FetchingSubscriber fetch with the default behavior: "get by specified selector".

Currently contains workaround with saved session, which must be removed as soon as new fetch method will be implemented in zenoh.

Testing:

  • modify z_query_sub example to call the queryable:
    add ze_querying_subscriber_get(z_loan(sub), z_keyexpr("demo/example/zenoh-c-queryable"), NULL); to the input check loop.
  • run z_pub_cache example
  • run z_queryable example
  • run z_query_sub and press some key periodically
  • check if z_query_sub receives the data from z_queryable

@sashacmc sashacmc changed the title Add ze_querying_subscriber_get method @sashacmc Add ze_querying_subscriber_get method Nov 23, 2023
@sashacmc sashacmc marked this pull request as ready for review November 23, 2023 15:10
@sashacmc
Copy link
Member Author

Seems CI failed because it require zenoh/master

@milyin milyin self-requested a review November 23, 2023 15:51
Copy link
Contributor

@milyin milyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me from code quality point of view, but I'd like to have it reviewed by someone who better knows the purpose of the update

include/zenoh_commons.h Show resolved Hide resolved
@JEnoch JEnoch merged commit 07550ba into eclipse-zenoh:master Nov 23, 2023
3 checks passed
@sashacmc sashacmc deleted the query_sub_fetch branch November 27, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants